Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change error code back #10042

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 11, 2024

Ticket

No ticket.

Description

Stray change from #10019.

Test Plan

CI passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 requested a review from a team as a code owner October 11, 2024 15:38
@cla-bot cla-bot bot added the cla-signed label Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 71b77ed
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67094673e33d980009f5ad79

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (2356f91) to head (71b77ed).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10042      +/-   ##
==========================================
- Coverage   54.62%   54.59%   -0.04%     
==========================================
  Files        1260     1260              
  Lines      157621   157621              
  Branches     3632     3632              
==========================================
- Hits        86102    86053      -49     
- Misses      71385    71434      +49     
  Partials      134      134              
Flag Coverage Δ
backend 45.33% <100.00%> (-0.10%) ⬇️
harness 72.74% <ø> (ø)
web 54.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_experiment.go 56.95% <100.00%> (ø)

... and 9 files with indirect coverage changes

@amandavialva01 amandavialva01 merged commit dd6aeda into main Oct 15, 2024
93 of 105 checks passed
@amandavialva01 amandavialva01 deleted the amanda/changeErrorCodeBack branch October 15, 2024 13:53
stoksc pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants