Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Datagrid filter to account for reoccuring metadata columns #10045

Closed
wants to merge 6 commits into from

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Oct 11, 2024

Ticket

ET-790

Description

Right now, if we have multiple metadata columns with the same name, there's no quick way of knowing of which type each one is while selecting it. This PR intends to add a descriptive text next to duplicate entries for the metadata columns.

Test Plan

  • make sure that you have at least one metadata column that is duplicated and, perhaps, of a different type
  • go to a experiment list
    • make sure that the grid visualization is enabled
  • open the filter
  • scroll down for the metadata column options
  • verify that the duplicates has a <column_name> - <column_type format

Screenshot 2024-10-11 at 15 46 42

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c18c78c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6709709b4d213a00084ff667
😎 Deploy Preview https://deploy-preview-10045--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-757 branch October 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant