Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Datagrid filter to account for reoccuring metadata columns #10046

Closed
wants to merge 2 commits into from

chore: ran lint

3f3ced0
Select commit
Loading
Failed to load commit list.
Closed

feat: update Datagrid filter to account for reoccuring metadata columns #10046

chore: ran lint
3f3ced0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 5, 2024 in 0s

50.90% (+0.01%) compared to cbf0bb1

View this Pull Request on Codecov

50.90% (+0.01%) compared to cbf0bb1

Details

Codecov Report

Attention: Patch coverage is 72.91667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.90%. Comparing base (cbf0bb1) to head (3f3ced0).

Files with missing lines Patch % Lines
...c/components/FilterForm/components/FilterField.tsx 37.03% 17 Missing ⚠️
webui/react/src/components/MultiSortMenu.tsx 86.20% 7 Missing and 1 partial ⚠️
webui/react/src/pages/FlatRuns/FlatRuns.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           thiago/ET-791   #10046      +/-   ##
=================================================
+ Coverage          50.89%   50.90%   +0.01%     
=================================================
  Files                953      953              
  Lines             130355   130426      +71     
  Branches            3653     3663      +10     
=================================================
+ Hits               66339    66394      +55     
- Misses             63882    63897      +15     
- Partials             134      135       +1     
Files with missing lines Coverage Δ
webui/react/src/components/ColumnPickerMenu.tsx 96.01% <100.00%> (ø)
...ui/react/src/components/FilterForm/TableFilter.tsx 80.20% <100.00%> (+0.20%) ⬆️
...omponents/FilterForm/components/FilterFormStore.ts 91.45% <100.00%> (+0.02%) ⬆️
webui/react/src/utils/flatRun.ts 99.24% <100.00%> (+<0.01%) ⬆️
webui/react/src/pages/FlatRuns/FlatRuns.tsx 11.27% <0.00%> (ø)
webui/react/src/components/MultiSortMenu.tsx 88.23% <86.20%> (-0.59%) ⬇️
...c/components/FilterForm/components/FilterField.tsx 57.21% <37.03%> (-0.44%) ⬇️