-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply config policy constraints to PATCH /experiments/:id #10048
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10048 +/- ##
=======================================
Coverage 54.42% 54.42%
=======================================
Files 1262 1262
Lines 158880 158880
Branches 3631 3630 -1
=======================================
+ Hits 86463 86469 +6
+ Misses 72283 72277 -6
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for finding and fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Same comment as here
Also, can we change the PR title to "apply priority constraints and check invariant config in PATCH /experiments/:id" (or something like that) after suggested changes are made ?
b881572
to
63f2f7f
Compare
63f2f7f
to
72bc3cf
Compare
Ticket
CM-564
Description
Pushing this check down a level makes sure it applies for
PATCH /api/v1/experiments/:id
calls, too.Test Plan
TBD.