Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply config policy constraints to PATCH /experiments/:id #10048

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 11, 2024

Ticket

CM-564

Description

Pushing this check down a level makes sure it applies for PATCH /api/v1/experiments/:id calls, too.

Test Plan

TBD.

@stoksc stoksc requested a review from a team as a code owner October 11, 2024 21:43
@stoksc stoksc requested a review from ShreyaLnuHpe October 11, 2024 21:43
@cla-bot cla-bot bot added the cla-signed label Oct 11, 2024
@stoksc stoksc requested a review from kkunapuli October 11, 2024 21:43
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 72bc3cf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/670e805208f97e0009803e2e

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.42%. Comparing base (2ef2f12) to head (72bc3cf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/experiment.go 80.00% 3 Missing ⚠️
master/internal/experiment_job_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10048   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files        1262     1262           
  Lines      158880   158880           
  Branches     3631     3630    -1     
=======================================
+ Hits        86463    86469    +6     
+ Misses      72283    72277    -6     
  Partials      134      134           
Flag Coverage Δ
backend 45.50% <75.00%> (+0.01%) ⬆️
harness 72.74% <ø> (ø)
web 53.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/experiment_job_service.go 7.50% <0.00%> (+2.04%) ⬆️
master/internal/experiment.go 33.70% <80.00%> (+0.99%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for finding and fixing this!

Copy link
Contributor

@ShreyaLnuHpe ShreyaLnuHpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Same comment as here
Also, can we change the PR title to "apply priority constraints and check invariant config in PATCH /experiments/:id" (or something like that) after suggested changes are made ?

@stoksc stoksc force-pushed the lower-experiment-set-priority-constraint-check branch from b881572 to 63f2f7f Compare October 15, 2024 14:41
@stoksc stoksc force-pushed the lower-experiment-set-priority-constraint-check branch from 63f2f7f to 72bc3cf Compare October 15, 2024 14:46
@stoksc stoksc merged commit 9efd96d into main Oct 15, 2024
82 of 94 checks passed
@stoksc stoksc deleted the lower-experiment-set-priority-constraint-check branch October 15, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants