Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: User Management test updates [CM-468] #10051

Merged
merged 3 commits into from
Oct 16, 2024
Merged

test: User Management test updates [CM-468] #10051

merged 3 commits into from
Oct 16, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Oct 14, 2024

Ticket

CM-468

Description

Makes changes to User Management tests. No major changes to test steps, mostly refactoring. Notable changes include:

  • Shares one test user between all single-user tests.
  • No longer keeps track of user state when not necessary.
  • Uses TestUser type instead of V1PostUserRequest to simplify code.

Test Plan

Should not require additional release party testing. Automated tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner October 14, 2024 18:31
@cla-bot cla-bot bot added the cla-signed label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.59%. Comparing base (30b197d) to head (67b38d6).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10051      +/-   ##
==========================================
- Coverage   54.61%   50.59%   -4.03%     
==========================================
  Files        1260      950     -310     
  Lines      157507   128863   -28644     
  Branches     3631     3631              
==========================================
- Hits        86030    65194   -20836     
+ Misses      71343    63535    -7808     
  Partials      134      134              
Flag Coverage Δ
harness ?
web 54.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 310 files with indirect coverage changes

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 67b38d6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/670d6370f9db0100089f4f75
😎 Deploy Preview https://deploy-preview-10051--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djanicekpach you might be interested in this review

@johnkim-det johnkim-det merged commit 2e8de9b into main Oct 16, 2024
88 of 100 checks passed
@johnkim-det johnkim-det deleted the CM-468 branch October 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants