feat: update ConfigPolicies with docs link [CM-558] #10055
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ? 'Configuration policies are being applied to the cluster.' | ||
| : 'Configuration policies are being applied to the workspace.'; |
There was a problem hiding this comment.
Removed "Global" because it's incorrect for workspaces, and seemed unnecessary for cluster, @tara-det-ai lmk if that's a problem
| const docsLink = ( | ||
| <Link external path={paths.docs('/manage/config-policies.html')} popout> | ||
| Learn more | ||
| </Link> | ||
| ); | ||
|
|
There was a problem hiding this comment.
this PR is merge blocked on #9969, which will add this page to the docs
There was a problem hiding this comment.
the final URL will be this:
https://docs.determined.ai/latest/manage/config-policies.html
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10055 +/- ##
==========================================
- Coverage 54.62% 50.59% -4.03%
==========================================
Files 1260 950 -310
Lines 157621 129012 -28609
Branches 3632 3633 +1
==========================================
- Hits 86102 65280 -20822
+ Misses 71385 63598 -7787
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
added additional fix here to disable Apply button on successful submit |
Ticket
CM-558
Description
Adds docs link to Alert component, per JIRA ticket.
Also includes other ConfigPolicies changes:
/policiesroute directly still checks permissions.Test Plan
in EE only, should see valid docs link in Alert on Config Policies page and Config Policies tab on Workspace Details page. Admin should see the link in the Alert with the "Apply" button. Non-admin should see the link in the Alert without the "Apply" button.
Checklist
docs/release-notes/See Release Note for details.