-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: introduce api search e2e test fixture #10061
Conversation
this introduces an e2e api fixture that returns objects that allow for api control of experiments. it should be useful for quickly scaffolding state before tests as well as imperatively updating the server state during tests.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10061 +/- ##
==========================================
- Coverage 54.26% 50.58% -3.69%
==========================================
Files 1259 953 -306
Lines 157276 130332 -26944
Branches 3642 3642
==========================================
- Hits 85344 65923 -19421
+ Misses 71799 64276 -7523
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not confident on how fixtures work but I had some questions while reading the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, though seeing a test using some of these new fixtures would be useful as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works for me. i was hoping to eliminate even more redundant code with orval
Ticket
ET-821
Description
this introduces an e2e api fixture that returns objects that allow for api control of experiments. it should be useful for quickly scaffolding state before tests as well as imperatively updating the server state during tests. This should fulfill ET-821 in that the fixture can be used to create experiments with trials as well as report metrics, checkpoints, and logs for the trial.
We also modify the existing api fixtures to:
Test Plan
No tests required
Checklist
docs/release-notes/
See Release Note for details.