-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove annotations requiring search ids in bulk action js (ET-241) #10062
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10062 +/- ##
==========================================
- Coverage 54.42% 54.41% -0.01%
==========================================
Files 1262 1262
Lines 158886 158886
Branches 3630 3631 +1
==========================================
- Hits 86472 86465 -7
- Misses 72280 72287 +7
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help!
Ticket
ET-241
Description
Removes annotations requiring fields that aren't actually logically required. Helps make the "select all" bulk action logic cleaner. There are some similar patterns on other bulk action APIs (like for experiments) but I'm less sure of the impact it'll have to change those so I think those should be handled separately if at all.
Test Plan
N/A
Checklist
docs/release-notes/
See Release Note for details.