Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove annotations requiring search ids in bulk action js (ET-241) #10062

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Oct 15, 2024

Ticket

ET-241

Description

Removes annotations requiring fields that aren't actually logically required. Helps make the "select all" bulk action logic cleaner. There are some similar patterns on other bulk action APIs (like for experiments) but I'm less sure of the impact it'll have to change those so I think those should be handled separately if at all.

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit cf5be6d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/670fe5ce4f8b4600081cb702
😎 Deploy Preview https://deploy-preview-10062--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.41%. Comparing base (7d6a1a7) to head (cf5be6d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10062      +/-   ##
==========================================
- Coverage   54.42%   54.41%   -0.01%     
==========================================
  Files        1262     1262              
  Lines      158886   158886              
  Branches     3630     3631       +1     
==========================================
- Hits        86472    86465       -7     
- Misses      72280    72287       +7     
  Partials      134      134              
Flag Coverage Δ
backend 45.49% <ø> (-0.02%) ⬇️
harness 72.74% <ø> (ø)
web 53.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@jesse-amano-hpe jesse-amano-hpe merged commit 6c46a46 into main Oct 16, 2024
82 of 94 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/search-ids-mark-optional branch October 16, 2024 17:46
hkang1 added a commit that referenced this pull request Nov 18, 2024
hkang1 added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants