Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix slices and maps merge test #10063

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 15, 2024

Ticket

CM-571

Description

fix slices and maps merge test. Change slice equality check method

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 requested a review from a team as a code owner October 15, 2024 21:29
@cla-bot cla-bot bot added the cla-signed label Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b92a9c9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/670edead75f0650008b29574

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.40%. Comparing base (2ef2f12) to head (b92a9c9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10063      +/-   ##
==========================================
- Coverage   54.42%   54.40%   -0.02%     
==========================================
  Files        1262     1262              
  Lines      158880   158880              
  Branches     3631     3631              
==========================================
- Hits        86463    86444      -19     
- Misses      72283    72302      +19     
  Partials      134      134              
Flag Coverage Δ
backend 45.46% <ø> (-0.04%) ⬇️
harness 72.74% <ø> (ø)
web 53.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@amandavialva01 amandavialva01 enabled auto-merge (squash) October 15, 2024 21:35
@amandavialva01 amandavialva01 merged commit 1d5c984 into main Oct 15, 2024
87 of 101 checks passed
@amandavialva01 amandavialva01 deleted the amanda/fixTestSlicesAndMaps branch October 15, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants