test: make explist e2e sort test more reliable #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this updates the experiment list e2e multi sort test: 1) the test could flake if the table was comparing numeric values lower than 10 with numeric values larger than 10. 2) the test helper now handles both the setup and scenario steps, allowing for more levels of sorting. the multi sort menu is also updated to output the values of the direction selector to the dom to allow selections during the e2e tests that don't need to be aware of the column copy.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10067 +/- ##
==========================================
- Coverage 54.41% 50.38% -4.03%
==========================================
Files 1262 952 -310
Lines 158886 130251 -28635
Branches 3632 3632
==========================================
- Hits 86454 65625 -20829
+ Misses 72298 64492 -7806
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thiagodallacqua-hpe
approved these changes
Oct 18, 2024
JComins000
reviewed
Oct 28, 2024
| await multiSortMenu.open(); | ||
| await multiSortMenu.multiSort.reset.pwLocator.click(); | ||
| // weirdness alert: reset closes the sort menu normally, but doesn't |
JComins000
reviewed
Oct 28, 2024
| await checkTableOrder('Trial count', 'Searcher Metric', true); | ||
| }); | ||
| }); | ||
| testSorts([ |
JComins000
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-828
Description
this updates the experiment list e2e multi sort test:
the test could flake if the table was comparing numeric values lower than 10 with numeric values larger than 10.
the test helper now handles both the setup and scenario steps, allowing for more levels of sorting.
the multi sort menu is also updated to output the values of the direction selector to the dom to allow selections during the e2e tests that don't need to be aware of the column copy.
Test Plan
react e2e tests should pass. will run back-to-back test suites on circleci to validate non-flakiness.
Checklist
docs/release-notes/See Release Note for details.