-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: version upgrade notification bug [CM-411] #10069
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10069 +/- ##
==========================================
- Coverage 54.62% 50.65% -3.97%
==========================================
Files 1260 950 -310
Lines 157621 128964 -28657
Branches 3632 3635 +3
==========================================
- Hits 86102 65328 -20774
+ Misses 71385 63503 -7882
+ Partials 134 133 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added few comments otherwise lgtm.
please double check (test) the behavior before merging it
Ticket
CM-411
Description
Fix bug where version upgrade notification would not having expected styling applied. This is addressed by adding
themeClass
to thenotification.warning
call.PR also includes:
Test Plan
Checklist
docs/release-notes/
See Release Note for details.