Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version upgrade notification bug [CM-411] #10069

Merged
merged 7 commits into from
Oct 22, 2024
Merged

fix: version upgrade notification bug [CM-411] #10069

merged 7 commits into from
Oct 22, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Oct 16, 2024

Ticket

CM-411

Description

Fix bug where version upgrade notification would not having expected styling applied. This is addressed by adding themeClass to the notification.warning call.

PR also includes:

  • Fix for intermittent UIProvider error by moving code into a component that renders with the other global app components.
  • Unrelated minor fix for console warning that I noticed while working on this.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner October 16, 2024 20:04
@cla-bot cla-bot bot added the cla-signed label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2f77e13
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6717ceaa03ebc900082c5ef0
😎 Deploy Preview https://deploy-preview-10069--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 71.11111% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.65%. Comparing base (2356f91) to head (2f77e13).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/App.tsx 0.00% 12 Missing ⚠️
webui/react/src/pages/SignIn.tsx 0.00% 9 Missing ⚠️
webui/react/src/utils/browser.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10069      +/-   ##
==========================================
- Coverage   54.62%   50.65%   -3.97%     
==========================================
  Files        1260      950     -310     
  Lines      157621   128964   -28657     
  Branches     3632     3635       +3     
==========================================
- Hits        86102    65328   -20774     
+ Misses      71385    63503    -7882     
+ Partials      134      133       -1     
Flag Coverage Δ
harness ?
web 54.47% <71.11%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/JupyterLabButton.tsx 100.00% <100.00%> (ø)
webui/react/src/components/VersionChecker.tsx 100.00% <100.00%> (ø)
webui/react/src/utils/browser.ts 46.55% <16.66%> (-1.24%) ⬇️
webui/react/src/pages/SignIn.tsx 0.00% <0.00%> (ø)
webui/react/src/App.tsx 0.00% <0.00%> (ø)

... and 310 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a bug in light mode

image

also could you add test plan?

webui/react/src/components/VersionChecker.tsx Outdated Show resolved Hide resolved
webui/react/src/components/VersionChecker.tsx Outdated Show resolved Hide resolved
webui/react/src/App.tsx Show resolved Hide resolved
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see many console errors

image

webui/react/src/components/VersionChecker.tsx Outdated Show resolved Hide resolved
@johnkim-det johnkim-det requested review from keita-determined and removed request for julian-determined-ai October 21, 2024 20:08
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added few comments otherwise lgtm.
please double check (test) the behavior before merging it

webui/react/src/App.tsx Show resolved Hide resolved
webui/react/src/components/VersionChecker.tsx Outdated Show resolved Hide resolved
webui/react/src/components/AuthToken.tsx Outdated Show resolved Hide resolved
webui/react/src/components/VersionChecker.tsx Show resolved Hide resolved
@johnkim-det johnkim-det merged commit 22ad457 into main Oct 22, 2024
82 of 94 checks passed
@johnkim-det johnkim-det deleted the CM-411 branch October 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants