Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests for the "move" experiment row action #10070

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Oct 16, 2024

Ticket

ET-663

Description

This Pr intends to add tests for the "move" experiment row action for the DataGrid.

Test Plan

  • run the 'Row Actions' test from the src/e2e/tests/experimentList.spec.ts test file.
  • all checks must pass

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c8fafb3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67192461ac20b300085fd3af

@thiagodallacqua-hpe thiagodallacqua-hpe changed the title thiago/ET-663 feat: add e2e tests for the "move" experiment row action Oct 16, 2024
@thiagodallacqua-hpe thiagodallacqua-hpe force-pushed the thiago/ET-663 branch 3 times, most recently from 397c7d7 to b781796 Compare October 21, 2024 22:07
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.77%. Comparing base (0013fd0) to head (c8fafb3).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10070      +/-   ##
==========================================
- Coverage   54.47%   53.77%   -0.70%     
==========================================
  Files        1267      447     -820     
  Lines      159437    77267   -82170     
  Branches     3637     3636       -1     
==========================================
- Hits        86856    41554   -45302     
+ Misses      72448    35580   -36868     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/ExperimentMoveModal.tsx 67.24% <100.00%> (+0.28%) ⬆️

... and 820 files with indirect coverage changes

webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
@thiagodallacqua-hpe thiagodallacqua-hpe enabled auto-merge (squash) October 23, 2024 15:22
@thiagodallacqua-hpe thiagodallacqua-hpe changed the base branch from main to thiago/ET-791 October 23, 2024 16:50
@thiagodallacqua-hpe thiagodallacqua-hpe requested a review from a team as a code owner October 23, 2024 16:50
@thiagodallacqua-hpe thiagodallacqua-hpe requested review from rb-determined-ai and removed request for a team October 23, 2024 16:50
@thiagodallacqua-hpe thiagodallacqua-hpe merged commit 3af0339 into main Oct 23, 2024
81 of 95 checks passed
@thiagodallacqua-hpe thiagodallacqua-hpe changed the base branch from thiago/ET-791 to main October 23, 2024 16:51
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-663 branch October 23, 2024 16:51
thiagodallacqua-hpe added a commit that referenced this pull request Oct 23, 2024
thiagodallacqua-hpe added a commit that referenced this pull request Oct 23, 2024
@thiagodallacqua-hpe thiagodallacqua-hpe restored the thiago/ET-663 branch October 28, 2024 17:14
thiagodallacqua-hpe added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants