-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add e2e tests for the "move" experiment row action #10070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opdown with move modal integration.
✅ Deploy Preview for determined-ui canceled.
|
thiagodallacqua-hpe
changed the title
thiago/ET-663
feat: add e2e tests for the "move" experiment row action
Oct 16, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 18, 2024 18:59
70c64a3
to
ba750c3
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 18, 2024 20:48
ba750c3
to
36ec636
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
3 times, most recently
from
October 21, 2024 22:07
397c7d7
to
b781796
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10070 +/- ##
==========================================
- Coverage 54.47% 53.77% -0.70%
==========================================
Files 1267 447 -820
Lines 159437 77267 -82170
Branches 3637 3636 -1
==========================================
- Hits 86856 41554 -45302
+ Misses 72448 35580 -36868
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 22, 2024 16:09
ef669df
to
be4bb55
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 22, 2024 17:14
be4bb55
to
74d1e28
Compare
johnkim-det
reviewed
Oct 22, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 22, 2024 20:04
f57ae54
to
4debcb7
Compare
johnkim-det
approved these changes
Oct 22, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 23, 2024 14:00
4debcb7
to
e5f497f
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-663
branch
from
October 23, 2024 16:29
e5f497f
to
c8fafb3
Compare
thiagodallacqua-hpe
requested review from
rb-determined-ai
and removed request for
a team
October 23, 2024 16:50
thiagodallacqua-hpe
added a commit
that referenced
this pull request
Oct 23, 2024
)" This reverts commit 3af0339.
thiagodallacqua-hpe
added a commit
that referenced
this pull request
Oct 23, 2024
thiagodallacqua-hpe
added a commit
that referenced
this pull request
Oct 23, 2024
)" This reverts commit 3af0339.
thiagodallacqua-hpe
added a commit
that referenced
this pull request
Oct 28, 2024
)" This reverts commit 3af0339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-663
Description
This Pr intends to add tests for the "move" experiment row action for the DataGrid.
Test Plan
'Row Actions'
test from thesrc/e2e/tests/experimentList.spec.ts
test file.Checklist
docs/release-notes/
See Release Note for details.