Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return error if workspace config violates global constraints #10076

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 17, 2024

Ticket

CM-575

Description

Return error if workspace invariant config violates global constraints

Test Plan

CI passes (automated testing)

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 requested a review from a team as a code owner October 17, 2024 15:39
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit b82cf31
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6716abacc11624000866c526
😎 Deploy Preview https://deploy-preview-10076--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 54.43%. Comparing base (912f91e) to head (b82cf31).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/configpolicy/utils.go 61.81% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10076      +/-   ##
==========================================
- Coverage   58.81%   54.43%   -4.39%     
==========================================
  Files         757     1267     +510     
  Lines      105981   159371   +53390     
  Branches     3631     3631              
==========================================
+ Hits        62330    86748   +24418     
- Misses      43517    72489   +28972     
  Partials      134      134              
Flag Coverage Δ
backend 45.66% <66.66%> (+1.86%) ⬆️
harness 72.55% <ø> (ø)
web 53.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_config_policies.go 86.59% <100.00%> (ø)
...ternal/configpolicy/postgres_task_config_policy.go 91.66% <100.00%> (ø)
master/internal/configpolicy/utils.go 71.53% <61.81%> (ø)

... and 507 files with indirect coverage changes

@amandavialva01 amandavialva01 force-pushed the amanda/CM575 branch 2 times, most recently from a13e804 to 58048fb Compare October 17, 2024 16:49
@amandavialva01 amandavialva01 force-pushed the amanda/CM575 branch 4 times, most recently from 423ac00 to f566a0c Compare October 18, 2024 18:43
Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change set can be simplified. Let's see if we can

  • use one function to unmarshal global config policies (whether NTSC or Experiment)
  • keep function names consistent

master/internal/configpolicy/utils.go Show resolved Hide resolved
master/internal/configpolicy/utils.go Outdated Show resolved Hide resolved
master/internal/configpolicy/utils.go Show resolved Hide resolved
Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@amandavialva01 amandavialva01 enabled auto-merge (squash) October 21, 2024 19:30
@amandavialva01 amandavialva01 merged commit 04861dd into main Oct 21, 2024
79 of 94 checks passed
@amandavialva01 amandavialva01 deleted the amanda/CM575 branch October 21, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants