Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: INFENG-922: use correct gh_team tag for infrastructure #10077

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

davidfluck-hpe
Copy link
Contributor

Ticket

INFENG-922

Description

This changeset fixes a tag/label value in the CircleCI config; gh_team: machine-user should be gh_team: machine-users (plural). This fixes some inconsistencies in cost tracking.

Test Plan

Probably unnecessary, although getting the test-e2e-hpc-gcp job to run would guarantee that the correct label is being applied. But unless label application isn't working at all, this only updates the value that's already being set.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@davidfluck-hpe davidfluck-hpe requested a review from a team as a code owner October 17, 2024 17:35
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 80b2029
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67114ae1a121e80008fa19cc
😎 Deploy Preview https://deploy-preview-10077--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (dadf75e) to head (80b2029).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10077      +/-   ##
==========================================
- Coverage   54.60%   54.60%   -0.01%     
==========================================
  Files        1260     1260              
  Lines      157635   157635              
  Branches     3632     3630       -2     
==========================================
- Hits        86082    86077       -5     
- Misses      71419    71424       +5     
  Partials      134      134              
Flag Coverage Δ
backend 45.37% <ø> (-0.01%) ⬇️
harness 72.74% <ø> (ø)
web 54.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@davidfluck-hpe davidfluck-hpe merged commit bdb56a4 into main Oct 18, 2024
86 of 98 checks passed
@davidfluck-hpe davidfluck-hpe deleted the INFENG-922-fix-machine-user-tags branch October 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants