fix: Tensorboard broken on unified install [CM-578] #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was just missed in: #8700
✅ Deploy Preview for determined-ui canceled.
|
stoksc
approved these changes
Oct 18, 2024
stoksc
reviewed
Oct 18, 2024
| @@ -286,6 +286,10 @@ func (a *apiServer) LaunchTensorboard( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if launchReq.Spec.Base.ExtraEnvVars == nil { | |||
There was a problem hiding this comment.
curse go for the zero value of slices being usable but the zero value for maps not, haha.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10080 +/- ##
==========================================
- Coverage 54.39% 54.38% -0.02%
==========================================
Files 1268 1268
Lines 159317 159319 +2
Branches 3631 3631
==========================================
- Hits 86668 86651 -17
- Misses 72515 72534 +19
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maxrussell
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was just missed in: #8700
Description
Test Plan