fix: Log search feedbacks #10088
Merged
fix: Log search feedbacks #10088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10088 +/- ##
==========================================
- Coverage 54.39% 50.39% -4.01%
==========================================
Files 1267 957 -310
Lines 159323 130590 -28733
Branches 3632 3631 -1
==========================================
- Hits 86670 65815 -20855
+ Misses 72519 64641 -7878
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
approved these changes
Oct 22, 2024
Comment on lines
484
to
490
| onClick={() => { | ||
| setSearchOn((prev) => !prev); | ||
| searchOn && setLogViewerOn(true); | ||
| searchOn && | ||
| selectedLog && | ||
| setScrollToIndex(logs.findIndex((l) => l.id === selectedLog.id)); | ||
| }}> |
There was a problem hiding this comment.
nit: this should be extracted out into a named function
| @@ -92,6 +93,9 @@ const TrialDetailsLogs: React.FC<Props> = ({ experiment, trial }: Props) => { | |||
|
|
|||
| useEffect(() => { | |||
| settings.searchText?.length && setSearchOn(true); | |||
| setSearchInput((prev) => | |||
| prev === (settings.searchText || '') ? prev : settings.searchText || '', | |||
There was a problem hiding this comment.
super nit: I think this could be slightly simplified to (prev === settings.searchText ? prev : settings.searchText) ?? ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
MD-529
Description
Address comments from log search bug bash.
Test Plan
Checklist
docs/release-notes/See Release Note for details.