-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: determined_master_host and friends helm support, better defaults #10092
Conversation
✅ Deploy Preview for determined-ui canceled.
|
4d68c85
to
1e5388c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10092 +/- ##
==========================================
- Coverage 54.49% 54.47% -0.02%
==========================================
Files 1267 1267
Lines 159437 159456 +19
Branches 3637 3636 -1
==========================================
- Hits 86885 86865 -20
- Misses 72419 72458 +39
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DetMasterIP string `json:"determined_master_ip,omitempty"` | ||
DetMasterPort int32 `json:"determined_master_port,omitempty"` | ||
// DeprecatedDetMasterHost shouldn't be used. Use the method DetMasterHost instead. | ||
DeprecatedDetMasterHost string `json:"determined_master_host,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxrussell if you know a better trick for this let me know
…ome better defaults
1e5388c
to
9b18d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could add that suggested test case, but I think it's okay without.
delete(rm, "determined_master_ip") | ||
} else { | ||
log.Warn("ignoring duplicated configuration `determined_master_ip`") | ||
delete(rm, "determined_master_ip") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, don't see a lot of delete
in Go.
}, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a test that ensures determined_master_host
is preferred when they're both set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super easy, i'll add it
…ts (#10092) When `determined_master_ip` is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renames `determined_master_ip` to `determined_master_host` everywhere with some backwards compatibility, defaults `determined_master_host` to `<det_namespace>.<det_service_name>.svc.cluster.local` instead of the service IP, and makes all of this overridable in Helm.
…ts (#10092) When `determined_master_ip` is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renames `determined_master_ip` to `determined_master_host` everywhere with some backwards compatibility, defaults `determined_master_host` to `<det_namespace>.<det_service_name>.svc.cluster.local` instead of the service IP, and makes all of this overridable in Helm.
Ticket
DFR-530 / DFR-529
Description
When
determined_master_ip
is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renamesdetermined_master_ip
todetermined_master_host
everywhere with some backwards compatibility, defaultsdetermined_master_host
to<det_namespace>.<det_service_name>.svc.cluster.local
, and makes all of this overridable in Helm.Test Plan
Tested manually.
Checklist
docs/release-notes/
See Release Note for details.