Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sorting for multi-type columns #10123

Merged
merged 2 commits into from
Oct 29, 2024

fix title for tests

4fde32e
Select commit
Loading
Failed to load commit list.
Merged

fix: improve sorting for multi-type columns #10123

fix title for tests
4fde32e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 59.30233% with 35 lines in your changes missing coverage. Please review.

Please upload report for BASE (thiago/ET-790@933c480). Learn more about missing BASE report.

Files with missing lines Patch % Lines
webui/react/src/pages/FlatRuns/FlatRuns.tsx 3.57% 27 Missing ⚠️
webui/react/src/components/MultiSortMenu.tsx 86.20% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             thiago/ET-790   #10123   +/-   ##
================================================
  Coverage                 ?   53.82%           
================================================
  Files                    ?      447           
  Lines                    ?    77383           
  Branches                 ?     3656           
================================================
  Hits                     ?    41648           
  Misses                   ?    35600           
  Partials                 ?      135           
Files with missing lines Coverage Δ
webui/react/src/components/MultiSortMenu.tsx 88.00% <86.20%> (ø)
webui/react/src/pages/FlatRuns/FlatRuns.tsx 11.03% <3.57%> (ø)