Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: checkpoint storage note for config policies #10153

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Oct 30, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2024
@determined-ci determined-ci requested a review from a team October 30, 2024 13:25
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2111f9e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67225e2b53665e000868850a
😎 Deploy Preview https://deploy-preview-10153--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

settings have different uses. Checkpoint storage set for a workspace is a default that can be overridden
by specifying checkpoint storage in experiment configuration. Experiment invariant config is
non-overridable and will replace any workspace defaults as well as user-submitted experiment configs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release note description of workspace checkpoint storage:
Checkpoint storage can now be configured at a workspace level. Experiments created in projects will now inherit checkpoint storage configuration from the project's workspace if set. Experiment configuration can override the workspace level checkpoint storage configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative suggestion:
Checkpoint storage can be configured for workspaces and in experiment invariant settings, but they have different functions. Workspace checkpoint storage serves as a default that can be overridden by experiment configurations, while experiment invariant settings are fixed and will override both workspace defaults and user-defined configurations.

@kkunapuli kkunapuli marked this pull request as ready for review October 30, 2024 13:40
@kkunapuli kkunapuli removed the request for review from amandavialva01 October 30, 2024 16:10
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkunapuli kkunapuli merged commit 83ea190 into main Oct 30, 2024
78 of 91 checks passed
@kkunapuli kkunapuli deleted the kunapuli/checkpoint-storage-docs-update branch October 30, 2024 16:39
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.38.0 cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants