Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in the release note #10183

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Oct 31, 2024

Ticket

Description

Fix typos in #10178

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 31, 2024
@determined-ci determined-ci requested a review from a team October 31, 2024 22:29
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0e90e9c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6724069e31bb4d00086e7958
😎 Deploy Preview https://deploy-preview-10183--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgongd jgongd force-pushed the jgong/fix-docs-pt-tb-plugin branch from 883f602 to 0e90e9c Compare October 31, 2024 22:37
@jgongd jgongd enabled auto-merge (squash) October 31, 2024 22:46
@jgongd jgongd disabled auto-merge October 31, 2024 22:46
Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jgongd jgongd merged commit 050db29 into main Oct 31, 2024
81 of 94 checks passed
@jgongd jgongd deleted the jgong/fix-docs-pt-tb-plugin branch October 31, 2024 22:48
Copy link

The backport to release-0.38.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-0.38.0 release-0.38.0
# Navigate to the new working tree
cd .worktrees/backport-release-0.38.0
# Create a new branch
git switch --create backport-10183-to-release-0.38.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 050db29c7db3341b838b14da55eaa95b3a21780d
# Push it to GitHub
git push --set-upstream origin backport-10183-to-release-0.38.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-0.38.0

Then, create a pull request where the base branch is release-0.38.0 and the compare/head branch is backport-10183-to-release-0.38.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.38.0 cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants