Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO-BACKPORT 10182] docs: docs changes for searcher context removal #10194

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 1, 2024

Backport f02872a from #10182.

update docs and add release note for searcher context removal in 0.38.0

(cherry picked from commit f02872a)
@github-actions github-actions bot requested review from a team as code owners November 1, 2024 23:25
@github-actions github-actions bot requested review from gt2345 and maxrussell and removed request for a team November 1, 2024 23:25
@cla-bot cla-bot bot added the cla-signed label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.32%. Comparing base (508d400) to head (32f402c).
Report is 2 commits behind head on release-0.38.0.

Files with missing lines Patch % Lines
...determined/pytorch/deepspeed/_deepspeed_context.py 55.55% 4 Missing ⚠️
master/pkg/searcher/searcher.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-0.38.0   #10194      +/-   ##
==================================================
- Coverage           54.32%   54.32%   -0.01%     
==================================================
  Files                1259     1259              
  Lines              157301   157310       +9     
  Branches             3644     3643       -1     
==================================================
+ Hits                85459    85461       +2     
- Misses              71709    71716       +7     
  Partials              133      133              
Flag Coverage Δ
backend 46.09% <0.00%> (-0.01%) ⬇️
harness 71.12% <55.55%> (-0.01%) ⬇️
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
harness/determined/pytorch/_trainer_utils.py 57.50% <ø> (ø)
harness/determined/pytorch/deepspeed/_trainer.py 49.54% <ø> (ø)
master/pkg/searcher/searcher.go 46.72% <0.00%> (ø)
...determined/pytorch/deepspeed/_deepspeed_context.py 62.68% <55.55%> (-0.34%) ⬇️

... and 2 files with indirect coverage changes

@carolinaecalderon carolinaecalderon merged commit 7db183e into release-0.38.0 Nov 4, 2024
73 of 86 checks passed
@carolinaecalderon carolinaecalderon deleted the backport-10182-to-release-0.38.0 branch November 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants