fix: performance errors when listing pods #10199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.35.0 #10199 +/- ##
===================================================
- Coverage 54.00% 43.31% -10.70%
===================================================
Files 1259 174 -1085
Lines 155373 18072 -137301
Branches 3498 0 -3498
===================================================
- Hits 83916 7828 -76088
+ Misses 71311 10244 -61067
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. |
amandavialva01
force-pushed
the
amanda/CM594
branch
3 times, most recently
from
f25211a to
0316375
Compare
amandavialva01
force-pushed
the
amanda/CM594
branch
from
0316375 to
21daf95
Compare
maxrussell
reviewed
Nov 6, 2024
| return nil, err | ||
| } | ||
| c.QPS = 100 | ||
| c.Burst = 100 | ||
| return rest.InClusterConfig() |
There was a problem hiding this comment.
Shouldn't this return c, err?
There was a problem hiding this comment.
This was ruled out as a viable solution before, I was testing solutions for a working fallback on a diff branch and I think i accidentally pushed this change here, I'll get rid of this
There was a problem hiding this comment.
but yea it woudlve had to be return c, err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-594
Description
fix performance errors when listing pods
Test Plan
CI passes (automated testing)
I'll also add a manual test plan for this
Checklist
docs/release-notes/See Release Note for details.