fix: perf issue with too many API reqs when listing pods in all ns #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0-35-1 #10200 +/- ##
==================================================
- Coverage 57.60% 53.03% -4.57%
==================================================
Files 762 454 -308
Lines 104257 75774 -28483
Branches 3498 3499 +1
==================================================
- Hits 60055 40190 -19865
+ Misses 44056 35438 -8618
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
force-pushed
the
backport-k8s-perf
branch
from
b179852 to
71adc45
Compare
stoksc
force-pushed
the
release-0-35-1
branch
from
0a44d21 to
f27fe28
Compare
stoksc
requested review from
kkunapuli,
hkang1,
jgongd and
molinamelendezj
and removed request for
a team
stoksc
force-pushed
the
backport-k8s-perf
branch
from
71adc45 to
fb8297c
Compare
kkunapuli
reviewed
Nov 8, 2024
| ctx context.Context, | ||
| opts metaV1.ListOptions, | ||
| ) ([]k8sV1.Pod, error) { | ||
| var g errgroup.Group |
There was a problem hiding this comment.
Is there a limit to the number of go funcs started at the same time? Or is it possible to wait on hundreds of go funcs?
There was a problem hiding this comment.
great question, no. i'd even added a g.SetLimit for this but the client they all use it already throttled so i decided i didn't care very much to limit it. this is already in fallback only code that is very unlikely to run.
kkunapuli
approved these changes
Nov 8, 2024
stoksc
force-pushed
the
release-0-35-1
branch
from
81f9205 to
98616f4
Compare
stoksc
force-pushed
the
release-0-35-1
branch
from
98616f4 to
b8f56b6
Compare
change burst and qps print list jobs performance improvement updates from brad
stoksc
force-pushed
the
backport-k8s-perf
branch
from
fb8297c to
c74808a
Compare
maxrussell
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Test Plan
Checklist
docs/release-notes/See Release Note for details.