Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete znode tests #10201

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

djanicekpach
Copy link
Contributor

@djanicekpach djanicekpach commented Nov 8, 2024

CI: Delete znode[TESTENG-130]

Description

znode tests are failing pretty regularly and it is rarely a real issue. Digging in to recent failures it's largely because znode has GPUs available on the runner where the GCP tests have them on the remote GCP host. Since it's extra maintenance and we effectively cover these tests in the GCP test, I'm deleting the last of the znode tests so we cna move on to more impactful tests.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f2a6f35
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/672e3f91cf9a500008f2543e

Copy link

@molinamelendezj molinamelendezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.36%. Comparing base (11a2581) to head (f2a6f35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10201      +/-   ##
==========================================
- Coverage   54.36%   54.36%   -0.01%     
==========================================
  Files        1259     1259              
  Lines      157346   157346              
  Branches     3653     3652       -1     
==========================================
- Hits        85544    85537       -7     
- Misses      71669    71676       +7     
  Partials      133      133              
Flag Coverage Δ
backend 46.15% <ø> (-0.02%) ⬇️
harness 71.14% <ø> (ø)
web 54.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@djanicekpach djanicekpach changed the title Djanicek/testeng 130/delete more znode ci: delete znode tests Nov 8, 2024
@djanicekpach djanicekpach merged commit e56dd5a into main Nov 13, 2024
91 of 107 checks passed
@djanicekpach djanicekpach deleted the djanicek/testeng-130/delete-more-znode branch November 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants