-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: delete znode tests #10201
Merged
Merged
ci: delete znode tests #10201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djanicekpach
requested review from
jesse-amano-hpe,
rb-determined-ai and
dannysauer
November 8, 2024 16:42
✅ Deploy Preview for determined-ui canceled.
|
dannysauer
approved these changes
Nov 8, 2024
molinamelendezj
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗑️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10201 +/- ##
==========================================
- Coverage 54.36% 54.36% -0.01%
==========================================
Files 1259 1259
Lines 157346 157346
Branches 3653 3652 -1
==========================================
- Hits 85544 85537 -7
- Misses 71669 71676 +7
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
Nov 8, 2024
djanicekpach
changed the title
Djanicek/testeng 130/delete more znode
ci: delete znode tests
Nov 8, 2024
rb-determined-ai
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: Delete znode[TESTENG-130]
Description
znode tests are failing pretty regularly and it is rarely a real issue. Digging in to recent failures it's largely because znode has GPUs available on the runner where the GCP tests have them on the remote GCP host. Since it's extra maintenance and we effectively cover these tests in the GCP test, I'm deleting the last of the znode tests so we cna move on to more impactful tests.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.