Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perf issue with too many API reqs when listing pods in all ns #10202

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Nov 8, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Nov 8, 2024
@determined-ci determined-ci requested a review from a team November 8, 2024 21:08
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 8, 2024
amandavialva01 and others added 2 commits November 8, 2024 16:09
change burst and qps

print

list jobs performance improvement

updates from brad
@stoksc stoksc force-pushed the backport-k8s-perf branch from 274ada5 to f6b34c1 Compare November 8, 2024 21:09
@determined-ci determined-ci removed the documentation Improvements or additions to documentation label Nov 8, 2024
@stoksc stoksc changed the title Backport k8s perf fix: perf issue with too many API reqs when listing pods in all ns Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (5b03599) to head (5b03599).
Report is 1 commits behind head on release-0.35.1.

Current head 5b03599 differs from pull request most recent head f6b34c1

Please upload reports for the commit f6b34c1 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.35.1   #10202   +/-   ##
===============================================
  Coverage           49.06%   49.06%           
===============================================
  Files                 719      719           
  Lines              101932   101932           
  Branches             3499     3499           
===============================================
  Hits                50015    50015           
  Misses              51771    51771           
  Partials              146      146           
Flag Coverage Δ
backend 43.77% <0.00%> (ø)
harness 38.42% <0.00%> (ø)
web 53.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@stoksc stoksc marked this pull request as ready for review November 8, 2024 21:10
@stoksc stoksc requested a review from a team as a code owner November 8, 2024 21:10
@stoksc stoksc requested review from ShreyaLnuHpe and removed request for a team November 8, 2024 21:10
@stoksc stoksc merged commit 46b3761 into release-0.35.1 Nov 8, 2024
11 of 53 checks passed
@stoksc stoksc deleted the backport-k8s-perf branch November 8, 2024 21:10
@stoksc stoksc restored the backport-k8s-perf branch November 15, 2024 21:33
maxrussell pushed a commit that referenced this pull request Nov 18, 2024
maxrussell pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants