Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert select all #10208

Merged
merged 9 commits into from
Nov 20, 2024
Merged

chore: revert select all #10208

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94c1fa9
Revert "fix: cover select all edge cases (#10187)"
hkang1 Nov 13, 2024
76a1a6a
Revert "feat: additional APIs to support "actual select all" function…
hkang1 Nov 13, 2024
7682987
Revert "feat: add actual select all to glide tables [ET-238] (#10081)"
hkang1 Nov 13, 2024
78ca197
Revert "refactor: remove annotations requiring search ids in bulk act…
hkang1 Nov 13, 2024
1c98a18
Revert "feat: bulk actions matching filters (ET-241) (#9895)"
hkang1 Nov 18, 2024
750299f
fix: add back in token code that is needed
hkang1 Nov 19, 2024
b470223
chore: update generated code
hkang1 Nov 19, 2024
5828df2
chore: update based on PR reviews
hkang1 Nov 20, 2024
9b7d857
chore: update generated files
hkang1 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
936 changes: 48 additions & 888 deletions harness/determined/common/api/bindings.py
View file
Open in desktop

Large diffs are not rendered by default.

768 changes: 0 additions & 768 deletions master/internal/api_searches.go
View file
Open in desktop

This file was deleted.

1,215 changes: 0 additions & 1,215 deletions master/internal/api_searches_intg_test.go
View file
Open in desktop

This file was deleted.

Binary file modified proto/buf.image.bin
View file
Open in desktop
Binary file not shown.
2,168 changes: 849 additions & 1,319 deletions proto/pkg/apiv1/api.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

708 changes: 3 additions & 705 deletions proto/pkg/apiv1/api.pb.gw.go
View file
Open in desktop

Large diffs are not rendered by default.

248 changes: 127 additions & 121 deletions proto/pkg/apiv1/run.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

1,457 changes: 0 additions & 1,457 deletions proto/pkg/apiv1/search.pb.go
View file
Open in desktop

This file was deleted.

311 changes: 42 additions & 269 deletions proto/pkg/apiv1/tensorboard.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

106 changes: 2 additions & 104 deletions proto/src/determined/api/v1/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import "determined/api/v1/notebook.proto";
import "determined/api/v1/project.proto";
import "determined/api/v1/rbac.proto";
import "determined/api/v1/run.proto";
import "determined/api/v1/search.proto";
import "determined/api/v1/task.proto";
import "determined/api/v1/template.proto";
import "determined/api/v1/tensorboard.proto";
Expand Down Expand Up @@ -1618,17 +1617,6 @@ service Determined {
tags: "Tensorboards"
};
}
// Launch a tensorboard for one or more searches using bulk search filters.
rpc LaunchTensorboardSearches(LaunchTensorboardSearchesRequest)
returns (LaunchTensorboardSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/tensorboards"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}
// Delete tensorboard files.
rpc DeleteTensorboardFiles(DeleteTensorboardFilesRequest)
returns (DeleteTensorboardFilesResponse) {
Expand Down Expand Up @@ -2687,7 +2675,7 @@ service Determined {
};
}

// Kill runs.
// Get a list of runs.
hkang1 marked this conversation as resolved.
Show resolved Hide resolved
rpc KillRuns(KillRunsRequest) returns (KillRunsResponse) {
option (google.api.http) = {
post: "/api/v1/runs/kill"
Expand All @@ -2698,7 +2686,7 @@ service Determined {
};
}

// Delete runs.
// Delete a list of runs.
rpc DeleteRuns(DeleteRunsRequest) returns (DeleteRunsResponse) {
option (google.api.http) = {
post: "/api/v1/runs/delete"
Expand Down Expand Up @@ -2855,96 +2843,6 @@ service Determined {
};
}

// Move searches.
rpc MoveSearches(MoveSearchesRequest) returns (MoveSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/move"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Cancel searches.
rpc CancelSearches(CancelSearchesRequest) returns (CancelSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/cancel"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Kill searches.
rpc KillSearches(KillSearchesRequest) returns (KillSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/kill"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Delete searches.
rpc DeleteSearches(DeleteSearchesRequest) returns (DeleteSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/delete"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Archive searches.
rpc ArchiveSearches(ArchiveSearchesRequest)
returns (ArchiveSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/archive"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Unarchive searches.
rpc UnarchiveSearches(UnarchiveSearchesRequest)
returns (UnarchiveSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/unarchive"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Pause experiment associated with provided searches.
rpc PauseSearches(PauseSearchesRequest) returns (PauseSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/pause"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Unpause experiment associated with provided searches.
rpc ResumeSearches(ResumeSearchesRequest) returns (ResumeSearchesResponse) {
option (google.api.http) = {
post: "/api/v1/searches/resume"
body: "*"
};
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_operation) = {
tags: "Internal"
};
}

// Create and get a user's access token
rpc PostAccessToken(PostAccessTokenRequest)
returns (PostAccessTokenResponse) {
Expand Down
30 changes: 16 additions & 14 deletions proto/src/determined/api/v1/run.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,12 @@ message RunActionResult {
// Request to move the run to a different project.
message MoveRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "source_project_id", "destination_project_id" ] }
json_schema: {
required: [ "source_project_id", "destination_project_id", "run_ids" ]
}
};

// The ids of the runs being moved. Leave empty if using filter.
// The ids of the runs being moved.
repeated int32 run_ids = 1;
// The id of the current parent project.
int32 source_project_id = 2;
Expand All @@ -94,9 +96,9 @@ message MoveRunsResponse {
// Kill runs.
message KillRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "source_project_id" ] }
json_schema: { required: [ "run_ids", "source_project_id" ] }
};
// The ids of the runs being killed. Leave empty if using filter.
// The ids of the runs being killed.
repeated int32 run_ids = 1;
// Project id of the runs being killed.
int32 project_id = 2;
Expand All @@ -115,9 +117,9 @@ message KillRunsResponse {
// Delete runs.
message DeleteRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "project_id" ] }
json_schema: { required: [ "run_ids" ] }
};
// The ids of the runs being deleted. Leave empty if using filter.
// The ids of the runs being deleted.
repeated int32 run_ids = 1;
// Project id of the runs being deleted.
int32 project_id = 2;
Expand All @@ -136,10 +138,10 @@ message DeleteRunsResponse {
// Request to archive the run
message ArchiveRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "project_id" ] }
json_schema: { required: [ "project_id", "run_ids" ] }
};

// The ids of the runs being archived. Leave empty if using filter.
// The ids of the runs being archived.
repeated int32 run_ids = 1;
// The id of the current parent project.
int32 project_id = 2;
Expand All @@ -160,10 +162,10 @@ message ArchiveRunsResponse {
// Request to unarchive the run
message UnarchiveRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "project_id" ] }
json_schema: { required: [ "project_id", "run_ids" ] }
};

// The ids of the runs being unarchived. Leave empty if using filter.
// The ids of the runs being unarchived.
repeated int32 run_ids = 1;
// The id of the current parent project.
int32 project_id = 2;
Expand All @@ -184,10 +186,10 @@ message UnarchiveRunsResponse {
// Request to pause the experiment associated witha run.
message PauseRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "project_id" ] }
json_schema: { required: [ "project_id", "run_ids", "skip_multitrial" ] }
};

// The ids of the runs being paused. Leave empty if using filter.
// The ids of the runs being moved.
repeated int32 run_ids = 1;
// The id of the project of the runs being paused.
int32 project_id = 2;
Expand All @@ -208,10 +210,10 @@ message PauseRunsResponse {
// Request to unpause the experiment associated witha run.
message ResumeRunsRequest {
option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = {
json_schema: { required: [ "project_id" ] }
json_schema: { required: [ "project_id", "run_ids", "skip_multitrial" ] }
};

// The ids of the runs being moved. Leave empty if using filter.
// The ids of the runs being moved.
repeated int32 run_ids = 1;
// The id of the project of the runs being unpaused.
int32 project_id = 2;
Expand Down
Loading
Loading