Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port k8s perf fix #10213

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: port k8s perf fix #10213

merged 1 commit into from
Nov 20, 2024

Conversation

maxrussell
Copy link
Contributor

@maxrussell maxrussell commented Nov 19, 2024

Description

Cherry picked the k8s performance fix into

Test Plan

Manually test k8s flows in release party

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e76d11e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673d0b1f5fc72e00089307fc

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.84%. Comparing base (258455d) to head (e76d11e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10213      +/-   ##
==========================================
+ Coverage   53.88%   57.84%   +3.96%     
==========================================
  Files        1257      752     -505     
  Lines      156507   103521   -52986     
  Branches     3653     3653              
==========================================
- Hits        84335    59885   -24450     
+ Misses      72039    43503   -28536     
  Partials      133      133              
Flag Coverage Δ
backend 43.80% <ø> (-2.27%) ⬇️
harness 67.37% <ø> (ø)
web 54.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 505 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxrussell
Copy link
Contributor Author

This was tested on earlier versions and seems to be only a problem in the automated test code. Merging so we can manually test.

@maxrussell maxrussell merged commit 50a28cd into main Nov 20, 2024
76 of 91 checks passed
@maxrussell maxrussell deleted the max/fwport-k8s-perf-fix branch November 20, 2024 20:27
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
Co-authored-by: Bradley Laney <[email protected]>
Co-authored-by: Amanda Vialva <[email protected]>
(cherry picked from commit 50a28cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants