Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix apex installation [DT-5] #10233

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Dec 3, 2024

Ticket

DT-5

Description

CI failed because the build was attempted on the master branch of the Apex repo. For reliability, it needs to be built on the latest release instead.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

CI failed because the build was attempted on the master branch of
the Apex repo. It needs to be built on the latest release instead.
@cla-bot cla-bot bot added the cla-signed label Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 244bc0f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/674f8a16e50adc0008d91340

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.35%. Comparing base (821e8a5) to head (244bc0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10233      +/-   ##
==========================================
- Coverage   54.37%   54.35%   -0.03%     
==========================================
  Files        1256     1256              
  Lines      155779   155779              
  Branches     3619     3617       -2     
==========================================
- Hits        84712    84667      -45     
- Misses      70934    70979      +45     
  Partials      133      133              
Flag Coverage Δ
backend 45.80% <ø> (-0.09%) ⬇️
harness 71.26% <ø> (ø)
web 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@jgongd jgongd marked this pull request as ready for review December 3, 2024 20:56
@jgongd jgongd requested a review from a team as a code owner December 3, 2024 20:56
Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jgongd jgongd merged commit ce78d62 into main Dec 4, 2024
82 of 94 checks passed
@jgongd jgongd deleted the jgong/ci-fix-apex-installation branch December 4, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants