Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test log pattern webhook cache #9922

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Sep 11, 2024

Description

metrics_sigma is no longer a field in single-medium-train-step.yaml. So the test need to be updated.

Test Plan

CI Passes.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

metrics_sigma is no longer a field in single-medium-train-step.yaml.
So the test need to be updated.
@jgongd jgongd requested a review from a team as a code owner September 11, 2024 20:12
@cla-bot cla-bot bot added the cla-signed label Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 66097d6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e1f9b6a14db20008581787

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (de89f68) to head (66097d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9922   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files         751      751           
  Lines      104454   104454           
  Branches     3598     3599    +1     
=======================================
  Hits        61824    61824           
  Misses      42498    42498           
  Partials      132      132           
Flag Coverage Δ
backend 43.80% <ø> (ø)
harness 72.75% <ø> (ø)
web 54.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jgongd jgongd merged commit 3900742 into main Sep 11, 2024
84 of 98 checks passed
@jgongd jgongd deleted the jgong/fix-test-log-pattern-webhook-cache branch September 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants