Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add projects tests [CM-467] #9928

Merged
merged 21 commits into from
Sep 16, 2024
Merged

test: add projects tests [CM-467] #9928

merged 21 commits into from
Sep 16, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Sep 12, 2024

Ticket

CM-467

Description

Adds e2e tests to cover filtering, sorting, and toggling the view on for WorkspaceProjects page.
Adds testing for moving a project to another workspace.
Splits workspaces and projects tests into separate files.

Test Plan

No additional release party testing required. Automated tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested review from a team as code owners September 12, 2024 20:10
@johnkim-det johnkim-det requested a review from gt2345 September 12, 2024 20:10
@cla-bot cla-bot bot added the cla-signed label Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f2a9fbd
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e47ea4dbcd7100085008b8

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 54.06%. Comparing base (6f36969) to head (f2a9fbd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/components/ProjectMoveModal.tsx 45.16% 17 Missing ⚠️
...t/src/pages/WorkspaceDetails/WorkspaceProjects.tsx 0.00% 11 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6f36969) and HEAD (f2a9fbd). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (6f36969) HEAD (f2a9fbd)
harness 8 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9928      +/-   ##
==========================================
- Coverage   59.18%   54.06%   -5.12%     
==========================================
  Files         751      442     -309     
  Lines      104462    75881   -28581     
  Branches     3597     3599       +2     
==========================================
- Hits        61824    41027   -20797     
+ Misses      42506    34722    -7784     
  Partials      132      132              
Flag Coverage Δ
harness ?
web 54.32% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t/src/pages/WorkspaceDetails/WorkspaceProjects.tsx 0.00% <0.00%> (ø)
webui/react/src/components/ProjectMoveModal.tsx 60.00% <45.16%> (+2.10%) ⬆️

... and 309 files with indirect coverage changes

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll give the approve, but please use safeName to avoid conflicts. CI could possibly conflict since the tests run 3 times each. each worker gets it's own user, but if you're ever scoped to all users, not using that util will become a problem

@johnkim-det johnkim-det merged commit 2d12be1 into main Sep 16, 2024
82 of 94 checks passed
@johnkim-det johnkim-det deleted the CM-467 branch September 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants