chore: fix global PUT for task config policies #9941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9941 +/- ##
==========================================
- Coverage 54.51% 54.50% -0.01%
==========================================
Files 1252 1252
Lines 156668 156668
Branches 3601 3599 -2
==========================================
- Hits 85411 85396 -15
- Misses 71124 71139 +15
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
kkunapuli
requested review from
corban-beaird,
amandavialva01 and
salonig23
and removed request for
corban-beaird
| @@ -45,9 +57,14 @@ message PutGlobalConfigPoliciesResponse { | |||
| // GetWorkspaceConfigPoliciesRequest lists task config policies | |||
| // for a given workspace and workload type. | |||
| message GetWorkspaceConfigPoliciesRequest { | |||
| option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = { | |||
| json_schema: { required: [ "workload_type" ] } | |||
There was a problem hiding this comment.
is workspace_id also required here?
There was a problem hiding this comment.
Great suggestion; I'll add it to all the workspace requests.
| @@ -76,9 +97,14 @@ message GetGlobalConfigPoliciesResponse { | |||
| // DeleteWorkspaceConfigPoliciesRequest is used to delete all task config | |||
| // policies for the workspace and workload type. | |||
| message DeleteWorkspaceConfigPoliciesRequest { | |||
| option (grpc.gateway.protoc_gen_swagger.options.openapiv2_schema) = { | |||
| json_schema: { required: [ "workload_type" ] } | |||
There was a problem hiding this comment.
Suggested change
| json_schema: { required: [ "workload_type" ] } | |
| json_schema: { required: [ "workload_type", "workspace_id" ] } |
(maybe this?)
amandavialva01
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-534
Description
Fix global PUT API for task config policies to include a parameter for the admin input.
Test Plan
None needed.
Checklist
docs/release-notes/See Release Note for details.