Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: can we apply invariant configs without a refactor? #9955

Closed
wants to merge 3 commits into from

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Sep 18, 2024

Ticket

Description

Will not merge. Illustration / test purposes only.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4ff2088
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66eb0e695e13de00087a6da8

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.11%. Comparing base (004c194) to head (4ff2088).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9955      +/-   ##
==========================================
+ Coverage   45.21%   52.11%   +6.89%     
==========================================
  Files         526      591      +65     
  Lines       54023    92187   +38164     
  Branches        0     3600    +3600     
==========================================
+ Hits        24428    48045   +23617     
- Misses      29595    44009   +14414     
- Partials        0      133     +133     
Flag Coverage Δ
harness 43.21% <ø> (?)
web 54.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1065 files with indirect coverage changes

@kkunapuli
Copy link
Contributor Author

@kkunapuli kkunapuli closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant