-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add database snapshot functionality to Helm chart #9956
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5b1bda7
to
a64649e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9956 +/- ##
==========================================
- Coverage 54.50% 54.49% -0.01%
==========================================
Files 1255 1255
Lines 156733 156733
Branches 3601 3600 -1
==========================================
- Hits 85424 85414 -10
- Misses 71176 71186 +10
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level, I like the values and docs! Left a couple comments of minor questions/suggestions. Approving, though, because they're optional if you don't think they'd be improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added suggested edits
6d190e3
to
1c4624d
Compare
Ticket
CM-448
Description
See notes: https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1748041758/Guide+Release+Party+Database+Backups
TLDR; add Helm values such that you can easily snapshot/backup OR restore a database's persistent volume.
Test Plan
Manual testing or N/A
Checklist
docs/release-notes/
See Release Note for details.