Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky generic task pause test #9962

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Sep 19, 2024

Ticket

Description

test is flaky, race between task going from PAUSING -> PAUSED and test check. so retry a few times.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

cla-bot bot commented Sep 19, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 914fce4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ed8626e6994400085ecc3f
😎 Deploy Preview https://deploy-preview-9962--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cla-bot bot commented Sep 19, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.50%. Comparing base (cedfcfe) to head (914fce4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9962      +/-   ##
==========================================
- Coverage   54.50%   51.50%   -3.01%     
==========================================
  Files        1255      710     -545     
  Lines      156729   102293   -54436     
  Branches     3601     3600       -1     
==========================================
- Hits        85423    52684   -32739     
+ Misses      71173    49476   -21697     
  Partials      133      133              
Flag Coverage Δ
backend 43.80% <ø> (-1.37%) ⬇️
harness 44.25% <ø> (-28.50%) ⬇️
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 700 files with indirect coverage changes

Copy link

cla-bot bot commented Sep 19, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

pause_resp = bindings.get_GetTask(sess, taskId=task_resp.taskId)
assert pause_resp.task.taskState == bindings.v1GenericTaskState.PAUSED
# The task may still be PAUSING, retry a few times.
retries = 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We could use task.wait_for_task_state(), but this solution is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh didn't see this, great! thanks!

Copy link

cla-bot bot commented Sep 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Sep 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@azhou-determined azhou-determined merged commit 3241edb into main Sep 20, 2024
78 of 93 checks passed
@azhou-determined azhou-determined deleted the fix-generic-task-test branch September 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants