-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix flaky generic task pause test #9962
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9962 +/- ##
==========================================
- Coverage 54.50% 51.50% -3.01%
==========================================
Files 1255 710 -545
Lines 156729 102293 -54436
Branches 3601 3600 -1
==========================================
- Hits 85423 52684 -32739
+ Misses 71173 49476 -21697
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
ee25e55
to
eefc4fd
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
|
pause_resp = bindings.get_GetTask(sess, taskId=task_resp.taskId) | ||
assert pause_resp.task.taskState == bindings.v1GenericTaskState.PAUSED | ||
# The task may still be PAUSING, retry a few times. | ||
retries = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We could use task.wait_for_task_state()
, but this solution is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh didn't see this, great! thanks!
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anda.
|
Ticket
Description
test is flaky, race between task going from PAUSING -> PAUSED and test check. so retry a few times.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.