fix: show - for empty data in searches table [ET-749]

[EmilyBonar]

Ticket

ET-749

Description

Test Plan

Make sure Flat Runs feature flag is on. Go into any project with a significant number of experiments (Uncategorized is a good default choice). Perform the following steps on both the Runs and Searches tabs.

• Turn on all columns using column picker
• Check that in every cell where no data is available, there is a - present

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	7c38e9e
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66f1bb9c7df9d400081ad7e3
😎 Deploy Preview	https://deploy-preview-9963--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 14.35185% with 185 lines in your changes missing coverage. Please review.

Project coverage is 50.46%. Comparing base (0db2e3b) to head (7c38e9e).
Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
webui/react/src/pages/FlatRuns/columns.ts	1.60%	123 Missing ⚠️
webui/react/src/components/Searches/columns.ts	13.88%	62 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9963      +/-   ##
==========================================
- Coverage   54.46%   50.46%   -4.00%     
==========================================
  Files        1252      944     -308     
  Lines      156703   128071   -28632     
  Branches     3600     3602       +2     
==========================================
- Hits        85341    64627   -20714     
+ Misses      71229    63311    -7918     
  Partials      133      133              

Flag	Coverage Δ
harness	?
web	54.31% <14.35%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../react/src/components/ExperimentActionDropdown.tsx	79.79% <100.00%> (ø)
webui/react/src/utils/table.ts	100.00% <100.00%> (ø)
webui/react/src/components/Searches/columns.ts	51.88% <13.88%> (+1.47%)	⬆️
webui/react/src/pages/FlatRuns/columns.ts	18.56% <1.60%> (-0.42%)	⬇️

... and 309 files with indirect coverage changes

[keita-determined]

added some comments, otherwise lgtm

[keita-determined]

can we update the test plan for the release party? and e2e ci failed

[EmilyBonar]

Requesting re-review due to significant changes. Open for feedback on argument/variable names, I was having trouble thinking of ones that were descriptive.

[keita-determined]

added one comment, otherwise lgtm

[keita-determined]

this works with the current columns, but if we wanna show EMPTY_CELL for special cases, this wouldnt work. For example, show - when data is EMPTY or -1 etc. i feel like its safer not to use handleEmptyCell. What do you think?

[EmilyBonar]

I think that seems unlikely, but in that case we could either update handleEmptyCell to deal with it or handle the special case when we call it, like handleEmptyCell(variable !== 'EMPTY' ? variable : undefined, ...

[keita-determined]

got it