Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reword jsonschema extension docs #9965

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: reword jsonschema extension docs #9965

merged 1 commit into from
Oct 1, 2024

Conversation

rb-determined-ai
Copy link
Contributor

No description provided.

@rb-determined-ai rb-determined-ai requested a review from a team as a code owner September 20, 2024 21:34
@cla-bot cla-bot bot added the cla-signed label Sep 20, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 02cea5e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66fb147ada6f350008aa7c82

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.25%. Comparing base (0db2e3b) to head (02cea5e).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9965      +/-   ##
==========================================
- Coverage   54.46%   54.25%   -0.21%     
==========================================
  Files        1252     1252              
  Lines      156703   156703              
  Branches     3600     3600              
==========================================
- Hits        85341    85019     -322     
- Misses      71229    71551     +322     
  Partials      133      133
Flag Coverage Δ
backend 45.17% <ø> (ø)
harness 71.34% <ø> (-1.13%) ⬇️
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/pkg/schemas/extensions/checks.go 93.93% <ø> (ø)

... and 23 files with indirect coverage changes

jgongd
jgongd approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jgongd jgongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this.

corban-beaird
corban-beaird approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid!

carolinaecalderon
carolinaecalderon approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rb-determined-ai rb-determined-ai enabled auto-merge (squash) September 30, 2024 21:13
@rb-determined-ai rb-determined-ai merged commit 49e72a8 into main Oct 1, 2024
82 of 94 checks passed
@rb-determined-ai rb-determined-ai deleted the rb/reword branch October 1, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgongd jgongd jgongd approved these changes

@carolinaecalderon carolinaecalderon carolinaecalderon approved these changes

@corban-beaird corban-beaird corban-beaird approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rb-determined-ai @corban-beaird @carolinaecalderon @jgongd