Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing factoryInstance.interface should return the exact contract interface type #872

Open
0xNeshi opened this issue Sep 22, 2023 · 0 comments

Comments

@0xNeshi
Copy link

0xNeshi commented Sep 22, 2023

When accessing Contract_factory.interface.encodeFunctionData (interface is of generic type Interface):
image

When accessing Contract__factory.createInterface().encodeFunctionData (interface is of specific type APTeamMultiSigInterface which enforces type-safety):
image

Without updating the former to return a properly typed interface, changes in function data or data types will not be registered by the typechain generation process, causing runtime failures.

With this update, we catch errors during compile-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@0xNeshi and others