Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using provider for readonly cases #97

Merged
merged 4 commits into from
May 14, 2022

Conversation

Pzixel
Copy link
Contributor

@Pzixel Pzixel commented May 7, 2022

Fixes #63

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2022

🦋 Changeset detected

Latest commit: 3df535e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@dethcrypto/eth-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Pzixel
Copy link
Contributor Author

Pzixel commented May 13, 2022

Ping?

@krzkaczor
Copy link
Member

Good stuff. Thanks for tweaking tests too. I'll release it in a second.

@krzkaczor krzkaczor merged commit 0ed5510 into dethcrypto:master May 14, 2022
@krzkaczor
Copy link
Member

@Pzixel Pzixel deleted the feature/provider branch May 14, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getMainnetSdk should allow provider or signer, not just signer
2 participants