Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error logging with default engine configuration #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix error logging with default engine configuration #64

wants to merge 2 commits into from

Conversation

deuill
Copy link
Owner

@deuill deuill commented Oct 7, 2018

By default, configuration values for log_errors and display_errors depend on how PHP has been
configured, and need to be made consistent in order for functionality to conform to expectations.

Additionally, the list of errors handled has been expanded to E_ALL instead of whatever the
default value is.

deuill added 2 commits October 7, 2018 15:37
@deuill
Fix error logging with default engine configuration
b197613 
By default, configuration values for `log_errors` and `display_errors` depend on how PHP has been
configured, and need to be made consistent in order for functionality to conform to expectations.

Additionally, the list of errors handled has been expanded to `E_ALL` instead of whatever the
default value is.
@deuill
Fix issues with comparing serialized floating-point numbers
f59ad77 
This commit fixes long-standing issues with comparing floating-point numbers bound into PHP with
their original numbers in Go, where issues with imprecise storage may cause errors to occur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deuill