Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution to cli issue - TypeError: Cannot read properties of undefined (reading 'fsPath') #895 #924

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

gauravsaini04
Copy link
Contributor

ref: #895

Description

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, left a comment for a possible improvement.

src/spec-node/featuresCLI/resolveDependencies.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small ask, otherwise ready for merging. Thanks.

src/spec-node/featuresCLI/resolveDependencies.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauravsaini04
Copy link
Contributor Author

LGTM!

Hi @chrmarti, as I don't have merging authorization, could you pls merge this

@eljog eljog merged commit bf230f4 into devcontainers:main Nov 21, 2024
19 checks passed
@gauravsaini04 gauravsaini04 deleted the cli_issue_#895_solution branch November 22, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants