Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] - solution to features issue #870 - unable to open codespace in jupyterlab #1156

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[python] - solution to features issue #870 - unable to open codespace in jupyterlab #1156

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27e8757
[python] - solution to features issue #870 - unable to open codespace…
gauravsaini04 Oct 21, 2024
f00006a
Merge branch 'devcontainers:main' into codespace_notopen_in_jupyterla…
gauravsaini04 Oct 24, 2024
56319a6
made $USER as dynamic value instead of hardcoded user
gauravsaini04 Oct 24, 2024
b1d913b
back
gauravsaini04 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"PYTHON_PATH": "/usr/local/python/current",
"PIPX_HOME": "/usr/local/py-utils",
"PIPX_BIN_DIR": "/usr/local/py-utils/bin",
"PATH": "/usr/local/python/current/bin:/usr/local/py-utils/bin:${PATH}"
"PATH": "/usr/local/python/current/bin:/usr/local/py-utils/bin:/usr/local/share/nvm/current/bin:/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/vscode/.local/bin:${PATH}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user name vscode is hard coded. Is that ideal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, This solution would prevent the feature from working for people who have specified the containerUser

},
"customizations": {
"vscode": {
Expand Down