Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to latest Github Actions Version #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated to latest Github Actions Version #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
},
"postCreateCommand": "npm install -g @devcontainers/cli",
"customizations": {
"editor.trimAutoWhitespace": true,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customization to handle whitespaces

"vscode": {
"extensions": [
"mads-hartmann.bash-ide-vscode",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
permissions:
packages: write
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: "Publish"
uses: devcontainers/action@v1
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
outputs:
templates: ${{ steps.filter.outputs.changes }}
steps:
- uses: dorny/paths-filter@v2
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
matrix:
templates: ${{ fromJSON(needs.detect-changes.outputs.templates) }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: "Install latest devcontainer CLI"
run: npm install -g @devcontainers/cli
Expand All @@ -74,7 +74,7 @@ jobs:
# Configure templates only if `devcontainer-template.json` contains the `options` property.
optionProp=( $(jq -r '.options' devcontainer-template.json) )

if [ "${optionProp}" != "" ] && [ "${optionProp}" != "null" ] ; then
if [ "${optionProp}" != "" ] && [ "${optionProp}" != "null" ] ; then
options=( $(jq -r '.options | keys[]' devcontainer-template.json) )

if [ "${options[0]}" != "" ] && [ "${options[0]}" != "null" ] ; then
Expand All @@ -101,7 +101,7 @@ jobs:
template_id="${{ matrix.templates }}"
src_dir="test/${template_id}"

if [ ! -d "$(pwd)/${src_dir}" ] ; then
if [ ! -d "$(pwd)/${src_dir}" ] ; then
echo "Template '${{ matrix.templates }}' is missing a test folder"
exit 1
fi
Expand All @@ -119,11 +119,11 @@ jobs:
# Fake out existence of extensions, VS Code Server to validate extensions
echo "(*) Stubbing out extensions and VS Code Server..."

# Configuring path for 'devcontainer.json'
# Configuring path for 'devcontainer.json'
dev_container_relative_path="src/${template_id}"
dev_container_json_name=".devcontainer.json"

if [ -d "$(pwd)/${dev_container_relative_path}/.devcontainer" ] ; then
if [ -d "$(pwd)/${dev_container_relative_path}/.devcontainer" ] ; then
dev_container_relative_path="${dev_container_relative_path}/.devcontainer"
dev_container_json_name="devcontainer.json"
fi
Expand All @@ -136,7 +136,7 @@ jobs:
# Fetching extensions list defined in 'devcontainer.json'
extensions="$(jq '.extensions' --compact-output "${dev_container_tmp}" | tr -d '[' | tr -d ']' | tr ',' '\n' 2>/dev/null || echo -n '')"

# Stubbing extensions list for the tests validation with checkExtension()
# Stubbing extensions list for the tests validation with checkExtension()
devcontainer exec --workspace-folder "src/${template_id}/" --id-label ${id_label} /bin/sh -c "\
mkdir -p \$HOME/.vscode-server/bin \$HOME/.vscode-server/extensions \
&& cd \$HOME/.vscode-server/extensions \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
pull-requests: write
if: "github.ref == 'refs/heads/main'"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Generate Documentation
uses: devcontainers/action@v1
Expand Down