Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definitions #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Silic0nS0ldier
Copy link

Addresses #21

I'm better at working with TypeScript on its own then I am at writing definitions, so let me know if I've screwed anything up.

Based on local integration testing, things seem to be working properly.

@Silic0nS0ldier
Copy link
Author

Failing tests appear to be the ones that failed locally (before and after implementing changes). I'll investigate further once I've the chance.

@Silic0nS0ldier
Copy link
Author

Test failures are probably down to 1 or more of the following

  1. Tests are incompatible with newer versions of Chrome.
  2. Dependencies have updated in a breaking way without using semver major. (karma failing to grab the version of Chrome and the OS seems to support this)
  3. Compiled source (babel, webpack, etc) are generating broken source (likely related to 2, if this is the case then updates cannot currently be published)

I'll continue investigate this more when I have the chance. Will probably end up rewriting the existing tests in the process (currently they look order sensitive, and from memory jest runs as much as it can in parallel). If there are any requests/preferences let me know.

@Silic0nS0ldier
Copy link
Author

Still looking into the unit tests. Didn't mention before, but I have tested against older versions of node. Implementation wise its I thinking it will be best to test using plain web workers (no abstractions), and with abstractions. Should help to identify compilation errors in the future (and may provide a test case for #8 ).

I did notice karmatic however it doesn't provide a mechanism for customising the configuration, which would be needed to use it here.

@developit
Copy link
Owner

@Silic0nS0ldier It's likely impossible to test TS stuff via Karmatic, since tests are executed in a browser environment.

@loucyx loucyx mentioned this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants