-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure tags must fit pattern before adding them #21
Open
mikemaccana
wants to merge
20
commits into
developit:master
Choose a base branch
from
certsimple:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
125e95a
Use .includes() rather than tilde & indexOf() trick
22ad80e
Don't add tag if it's invalid (eg, for pattern=). Fixes #20
1bf5ecd
Build files and bump version
a649501
Use a better seperator. Handle newlines, various other seperators.
32a933b
Remove AMD and global crap from build
ea4df5c
Rebuild and bump version
51a5c66
Remove maps, HTML, bower, babel files and other unncessary bits (user…
b3b97d2
Use my editorconfig
67570f7
Remove jshintrc (we use eslint)
93e29c2
Add tests for splitting input
709bfd1
Neaten selector function
00eab78
Clean less, jslint etc from package.json
071bd52
Run through prettier-eslint - fixes odd conditionals
e7bfb22
Use array for array.
3d2550f
Unminiify variables
e741a72
More cleanup
fe23a5b
Scope
d0686de
Update readme
6e7b4c3
Add license properly
440f116
Fix bad import and bump ver
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems a shame to give up IE compat here