-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Pass extra argument to actions #183
Open
lkmill
wants to merge
19
commits into
developit:master
Choose a base branch
from
lkmill:feature/extra-arguments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkmill
force-pushed
the
feature/extra-arguments
branch
from
December 2, 2019 20:18
415d795
to
c3c483b
Compare
This was referenced Dec 27, 2019
Closed
lkmill
force-pushed
the
feature/extra-arguments
branch
2 times, most recently
from
April 6, 2020 15:56
619f1b7
to
3732880
Compare
lkmill
force-pushed
the
feature/extra-arguments
branch
from
April 6, 2020 16:26
3732880
to
e0363c9
Compare
lkmill
force-pushed
the
feature/extra-arguments
branch
from
April 7, 2020 14:06
e0363c9
to
157fac7
Compare
lkmill
force-pushed
the
feature/extra-arguments
branch
from
April 16, 2020 16:22
157fac7
to
04bdd86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option to initialize a store with an extra argument that will be passed to each invocation of action functions. This is very similar to the extra argument option in redux-thunk#injecting-a-custom-argument.
This branch is based on my new actions branch/PR. The other branch should be merged before this as implementing this functionality on the current actions logic would get kind of confusing.
Why?
Isomorphic actions / SSR
There are several use cases, an obvious one is passing different fetch implementations or similar
depending on if it is server or client side rendered.
Easier testing
If the action uses browser globals, they have to be mocked:
To test the following either a mock server has to be running, or something like proxyquire be used:
Both problems above are solved by passing in a
fetch
argument. Then we simply pass in a mockfetch
when testing:Build Size