Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): update deprecated actions #2310

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ReenigneArcher
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Some actions are deprecated and will automatically fail the job if those versions are specified.

See: https://github.com/ReenigneArcher/devicon/actions/runs/12240230225/job/34142538368

This PR closes NONE

Notes

  • Trailing white space was removed.
  • Indentation of types: was corrected in the peek_icons.yml workflow.

@Snailedlt
Copy link
Collaborator

@ReenigneArcher Have you tested that these workflows still work after updating to newer versions?

@ReenigneArcher
Copy link
Author

Someone more familiar with this project should probably do that (I wouldn't know what to check for). I did check for breaking behavior changes though, and I don't believe there are any.

Most of these actions I have updated myself in https://github.com/LizardByte over the years, throughout our 50+ repos, and not seen any issues.

@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team December 14, 2024 17:42
@Snailedlt Snailedlt added the devops Use this label for devops related enhancements label Dec 14, 2024
@Snailedlt
Copy link
Collaborator

Snailedlt commented Dec 14, 2024

Hmm, I don't have time to test all of them any time soon.
@canaleal do you have time to test these workflows any time soon?

If not I suggest we either:

  1. wait until one of the maintainers have time to test this
    or
  2. Merge it, and fix any changes we detect afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants