[feature] Candidate Postings #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethetter
reviewed
Jan 15, 2023
| } | ||
| } | ||
|
|
||
| return errs |
There was a problem hiding this comment.
Thoughts on adding a validation for both compensation fields to be present? Either both missing, or both provided.
sethetter
reviewed
Jan 15, 2023
| <span class="form-error">{{ . }}</span> | ||
| {{ end }} | ||
| {{ end }} | ||
| <input type="phone" name="phone" class="form-input mb-3" value=""> |
There was a problem hiding this comment.
Could be good to call out that this gets displayed publicly on the view page. I suppose email as well.
sethetter
reviewed
Jan 15, 2023
|
|
||
| func slackMessageFromRole(role data.Role, c *config.Config) SlackMessage { | ||
| text := fmt.Sprintf( | ||
| "A new resume was posted!\n> *<%s/roles/%s|%s @ %s>*", |
There was a problem hiding this comment.
Suggested change
| "A new resume was posted!\n> *<%s/roles/%s|%s @ %s>*", | |
| "A new resume was posted!\n> *<%s/roles/%s|%s (%s)>*", |
| website TEXT NULL, | ||
| github TEXT NULL, | ||
| comp_low TEXT NULL, | ||
| comp_high TEXT NULL, |
There was a problem hiding this comment.
curious why comp_* uses TEXT rather than a numeric or money type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new set of pages and table to handle candidates posting that they're looking for work