Skip to content

Commit

Permalink
Enable ImageCaptureReaderTest
Browse files Browse the repository at this point in the history
This test was disabled in bisq-network#7109 due to encountering dependency issues.
Using a newer version of the JavaFX Gradle Plugin should hopefully
resolve those issues since a similar issue [1] was fixed in v0.0.11
when they added M1 Mac support.

[1] openjfx/javafx-gradle-plugin#112
  • Loading branch information
devinbileck committed Jun 23, 2024
1 parent ed3490c commit f357266
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

Expand All @@ -40,13 +39,6 @@
import org.bytedeco.javacv.Frame;
import org.bytedeco.javacv.FrameGrabber;

// TODO fix dependency problems
// If tests are run via gradle I get an error:
// `Loading library prism_es2 from resource failed: java.lang.UnsatisfiedLinkError: Can't load library: /Users/dev/.openjfx/cache/16/libprism_es2.dylib`
// If run from the IDE it works.
// CI on windows also fails, other OS work.
// Seems that there are some platfomr specific dependency issues...
@Disabled
@ExtendWith(MockitoExtension.class)
class ImageCaptureReaderTest {
@Mock
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ lombok = { strictly = '1.18.22' }
mockito = { strictly = '4.0.0' }
natpryce-make-it-easy = { strictly = '4.0.1' }
netlayer = { strictly = '2b459dc' }
openjfx-javafx-plugin = { strictly = '0.0.10' }
openjfx-javafx-plugin = { strictly = '0.1.0' }
protobuf = { strictly = '3.19.1' }
pushy = { strictly = '0.13.10' }
qrgen = { strictly = '1.3' }
Expand Down

0 comments on commit f357266

Please sign in to comment.