Fix premature exit #135
Open
Fix premature exit #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I met a lot of the following error logs when I execute `init:stop()` ``` 14:46:29.924 [error] Undefined:Undefined gen_server <0.1199.0> terminated with reason: killed 14:46:29.924 [error] Undefined:Undefined CRASH REPORT Process <0.1199.0> with 0 neighbours exited with reason: killed in gen_server:decode_msg/9 line 432 ``` And terminate function of mysql_conn.erl didn't get fully executed. I have a pool size of 1600, maybe this caused this problem to be obvious. Because `exit(State#state.supervisor, shutdown)` is async shutdown, the pool process passed away immediately, so State#state.supervisor gets also killed, Now that parent of all workers is dead, so workers show messages pasted above(gen_server:decode_msg/9 line 432), So we need to wait a little bit to allow workers to terminate properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I met a lot of the following error logs when I execute
init:stop()And terminate function of mysql_conn.erl didn't get fully executed.
I have a pool size of 1600, maybe this caused this problem to be obvious.
Because
exit(State#state.supervisor, shutdown)is async shutdown, the pool process passed away immediately,so State#state.supervisor gets also killed,
Now that parent of all workers is dead, so workers show messages pasted above(gen_server:decode_msg/9 line 432),
So we need to wait a little bit to allow workers to terminate properly.