-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 #75
base: master
Are you sure you want to change the base?
Conversation
Why are you going to remove support for pre-17.0? |
@jinnipark It will only happen once 18.0 is released, at which point R16 will be two versions out of date. |
gen_server:reply(From, Pid), | ||
State#state{waiting = Left}; | ||
{empty, Empty} when Overflow > 0 -> | ||
case ets:first(Waiting) of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Waiting
ets table is of type set so dequeues are random or rather hash based. This is interesting but likely leads to the large 99% latencies of LIFO queues because a process hashed to an unlucky bucket will effectively be at the end of the queue, with newer process jumping ahead of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was operating based on my assumption that the first key according to the table's internal order will be returned (Erlang docs) meant there would order based on time of insertion, not hashed based on the waiting pid. That's unfortunate if that's how it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will be disappointed I'm afraid :(.
Hi @devinus, I was wondering if this is still in working? Thanks |
start/1
handle_*
fall-throughssys:get_status()
queue
for the workers